This extension is still not approved. The phpBB extension review team found more issues, all very minor.
It’s taken a long time to put out a new release because I had to wait a few months for a review, and then I had to puzzle my way through bugs that were introduced into phpBB’s migrator in phpBB 3.2.2 which in many cases kept digests from installing correctly. It’s all pretty annoying but issues like this are bound to creep in from time to time. Anyhow, version 3.2.7 is released. With this release I’ve retested installing digests from a database upgraded from phpBB 3.0 with the digests mod installed. Apparently I hadn’t retested this since the 3.1 version of digests. Using this approach you can retain your digest settings from the mod.
You can download this version from my digests extension page or on the GitHub branch.
Most of the change log is pretty technical and arguably irrelevant but you should pay attention to bug fixes and functionality changes.
Bug fixes:
- Fixed HTML5 validation issue with Edit Subscribers, closing </textarea> was missing
- Fixed HTML5 validation issue with Balance Load, added three <col> tags
- UCP dialog error fixed by adding additional code to jQueryUI interface
- Moved posts are not included in a digest
- Configuration variable phpbbservices_digests_strip_tags added by the migrator, was missed from earlier version
Changes in functionality:
- When the manual mailer is run, the file name includes a hash for added security
Extension team review fixes:
- Replaced isset($_REQUEST[‘config’]) with $this->request->is_set(‘config’)
- Replaced addslashes($balance) with $this->db->sql_escape($balance)
- Removed !defined(‘IN_PHPBB’) in mailer
- Moved code to load messenger class inside the mail_digests function in cron/task/digests.php
Best practices:
- Replaced sizeof() with count() as sizeof() is an alias of count()
- Removed redundant conditional operators where unnecessary
- Removed unneeded casting of function return values where unnecessary
- Used $html_messenger->assign_var() when only one template variable needed to be set instead of $html_messenger->assign_vars()
CSS:
- Included ACP and UCP .css file through a switch, so they would not be loaded by other modules
- Edit subscribers now shows alternating row colors properly
Javascript:
- Included ACP and UCP .js file through a switch, so they would not be loaded by other modules
- Fixed some variable names that were not using camelcase
- addToStack() function logic now uses jQuery
- Removed redundant conditional operators where unnecessary
- Added var in front of variables that did not use them
ACP Interface:
- Removed query for f_list privilege, unneeded
- Used constants DIGESTS_DAILY_VALUE, DIGESTS_WEEKLY_VALUE and DIGESTS_MONTHLY_VALUE instead of literals
- Properly indented code in templates
UCP Interface:
- Properly indented code in templates
services.xml:
- helper class is no longer passed to main_listener class as it is no longer needed
html_messenger.php:
- Brought copied functions up to date with functions in version 3.2.2 of /includes/functions_messenger.php
Migrations:
- Lots of work to simplify and address issues, some related to bugs in the migrator introduced in phpBB 3.2.2
- Conversion from digests mod: now properly converts configuration variables, modules and schema changes during enabling the extension if these remain in the database after upgrading from phpBB 3.0. This allows digest settings to be retained. Apparently this functionality never worked on phpBB 3.2. To get around what look like migrator bugs in phpBB 3.2.2, old modules are deleted with a direct database call. Note: if AutoMOD was used to install Digests, you need to remove AutoMOD modules manually. The symptom is an ACT_CAT_MOD tab appears in the ACP.
- Updates configuration variable to point to new digests web page URL
- Helper container removed as it is no longer needed
- release_3_0_6.php removed
- common.php linkage removed as it is not used anymore
